Clean up append_multipath() code to copy files in a loop and report file that failed to copy

ChangeLog

@@ -2,6 +2,10 @@
 # Copyright 1999-2009 Gentoo Foundation; 2008-2009 Various authors (see AUTHORS)
 # Distributed under the GPL v2
 
+  06 Mar 2009; Andrew Gaffney <agaffney@gentoo.org> gen_initramfs.sh:
+  Clean up append_multipath() code to copy files in a loop and report file
+  that failed to copy
+
   06 Mar 2009; Andrew Gaffney <agaffney@gentoo.org> gen_initramfs.sh:
   Apply patch from robbat2 to fix whitespace breakage in multipath code
 

gen_initramfs.sh

@@ -135,32 +135,28 @@ append_multipath(){
 	mkdir -p "${TEMP}/initramfs-multipath-temp/etc/" 
 	mkdir -p "${TEMP}/initramfs-multipath-temp/sbin/"
 	mkdir -p "${TEMP}/initramfs-multipath-temp/lib/"
-	cp -a /lib/ld-* "${TEMP}/initramfs-multipath-temp/lib" \
+
-		|| gen_die 'Could not copy files for MULTIPATH!' 
+	# Copy files to /lib
-	cp -a /lib/libc-* /lib/libc.* "${TEMP}/initramfs-multipath-temp/lib" \
+	for i in /lib/{ld-*,libc-*,libc.*,libdl-*,libdl.*,libsysfs*so*,libdevmapper*so*}
-		|| gen_die 'Could not copy files for MULTIPATH!'
+	do
-	cp -a /lib/libdl-* /lib/libdl.* "${TEMP}/initramfs-multipath-temp/lib" \
+		cp -a "${i}" "${TEMP}/initramfs-multipath-temp/lib" \
-		|| gen_die 'Could not copy files for MULTIPATH!'
+			|| gen_die "Could not copy file ${i} for MULTIPATH"
-	cp -a /lib/libsysfs*so* "${TEMP}/initramfs-multipath-temp/lib" \
+	done
-		|| gen_die 'Could not copy files for MULTIPATH!'
+
-	cp -a /lib/libdevmapper*so* "${TEMP}/initramfs-multipath-temp/lib" \
+	# Copy files to /sbin
-		|| gen_die 'Could not copy files for MULTIPATH!'
+	for i in /sbin/{multipath,kpartx,mpath_prio_*,devmap_name,dmsetup} /lib64/udev/scsi_id
-	cp -a /sbin/multipath "${TEMP}/initramfs-multipath-temp/sbin" \
+	do
-		|| gen_die 'Could not copy files for MULTIPATH!'
+		cp -a "${i}" "${TEMP}/initramfs-multipath-temp/sbin" \
-	cp -a /sbin/kpartx "${TEMP}/initramfs-multipath-temp/sbin" \
+			|| gen_die "Could not copy file ${i} for MULTIPATH"
-		|| gen_die 'Could not copy files for MULTIPATH!'
+	done
-	cp -a /sbin/mpath_prio_* "${TEMP}/initramfs-multipath-temp/sbin" \
+
-		|| gen_die 'Could not copy files for MULTIPATH!'
+	# Copy files to /bin
-	cp -a /lib64/udev/scsi_id "${TEMP}/initramfs-multipath-temp/sbin" \
+	for i in /bin/mountpoint
-		|| gen_die 'Could not copy files for MULTIPATH!'
+	do
-	cp -a /sbin/devmap_name "${TEMP}/initramfs-multipath-temp/sbin" \
+		cp -a "${i}" "${TEMP}/initramfs-multipath-temp/bin" \
-		|| gen_die 'Could not copy files for MULTIPATH!'
+			|| gen_die "Could not copy file ${i} for MULTIPATH"
-	cp -a /sbin/dmsetup "${TEMP}/initramfs-multipath-temp/sbin" \
+	done
-		|| gen_die 'Could not copy files for MULTIPATH!'
+
-	cp -a /sbin/dmsetup "${TEMP}/initramfs-multipath-temp/sbin" \
-		|| gen_die 'Could not copy files for MULTIPATH!'
-	cp -a /bin/mountpoint "${TEMP}/initramfs-multipath-temp/bin" \
-		|| gen_die 'Could not copy files for MULTIPATH!'
 	if [ -x /sbin/multipath ] 
 	then
 		cp /etc/multipath.conf "${TEMP}/initramfs-multipath-temp/etc/" || gen_die 'could not copy /etc/multipath.conf please check this'