rpmlint and lintian fixes, still not done

rpmlint only left: battery-status-led.noarch: W: manpage-not-compressed bz2 /usr/share/man/man1/battery-status-led.1.gz battery-status-led.noarch: E: no-signature battery-status-led.noarch: E: no-dependency-on locales-led lintian left: W: battery-status-led: new-package-should-close-itp-bug W: battery-status-led: non-standard-dir-perm lib/ 0775 != 0755 W: battery-status-led: non-standard-dir-perm lib/systemd/ 0775 != 0755 W: battery-status-led: non-standard-dir-perm usr/ 0775 != 0755 W: battery-status-led: non-standard-dir-perm ... use --no-tag-display-limit to see all (or pipe to a file/program)
6 years ago · bd6e9a4ad6
parent f1cdd4132e
commit bd6e9a4ad6
3 changed files with 70 additions and 18 deletions
--- a/battery-status-led.1
+++ b/battery-status-led.1
@ -1,14 +1,15 @@
 .TH BATTERY-STATUS-LED 1 LOCAL

 .SH NAME
-
-Battery Status LED - Battery (low/critical) status indication by making a (the 
-capslock) LED blink
+.B battery-status-led
+\- Blink a LED on low battery

 .SH SYNOPSIS
-.B battery-status-led
+battery-status-led

 .SH DESCRIPTION
+Battery (low/critical) status indication by making a (the capslock) LED blink
+
 Takes no argument. To pick another LED device, edit
 .I /lib/systemd/system/battery-status-led.service
 and modify
@ -17,11 +18,15 @@ to something else. The default value is
 .I /sys/class/leds/input4\:\:capslock

 .SH AUTHOR
-Denes Matetelki <denes.matetelki@gmail.com>
+.MT denes.matetelki@gmail.com
+Denes Matetelki
+.ME

 .SH SEE ALSO

-Homepage at: <https://github.com/dmatetelki/battery-status-led/>
+Homepage:
+.UR https://github.com/dmatetelki/battery-status-led/
+.UE

 .br
 Copyright © 2018 Denes Matetelki.
--- a/debian/package-deb.sh
+++ b/debian/package-deb.sh
@ -30,22 +30,61 @@ Section: misc
 Priority: optional
 Architecture: amd64
 Maintainer: Denes Matetelki <denes.matetelki@gmail.com>
-Description: Battery Status LED
-  Battery (low/critical) status indication by making a (the capslock) LED blink"
+Description: Blink a LED on low battery
+ Battery (low/critical) status indication by making a (the capslock) LED blink"
 EOL

-mkdir -p build/${NAME}_${VERSION}/lib/systemd/system
+cat > build/copyright <<EOL
+Copyright (c) 2018 Denes Matetelki
+
+License: GPL-3+
+ This program is free software; you can redistribute it
+ and/or modify it under the terms of the GNU General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License, or (at your option) any later
+ version.
+ .
+ This program is distributed in the hope that it will be
+ useful, but WITHOUT ANY WARRANTY; without even the implied
+ warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+ PURPOSE.  See the GNU General Public License for more
+ details.
+ .
+ You should have received a copy of the GNU General Public
+ License along with this package; if not, write to the Free
+ Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+ Boston, MA  02110-1301 USA
+ .
+ On Debian systems, the full text of the GNU General Public
+ License version 3 can be found in the file
+ '/usr/share/common-licenses/GPL-3'.
+EOL
+
+cat > build/changelog.Debian <<EOL
+battery-status-led (0.1-1) misc; urgency=low
+
+  * Initial release
+
+ -- Denes Matetelki <denes.matetelki@gmail.com>  Fri, 31 Aug 2018 12:00:00 +0100
+EOL
+
+mkdir -m 0755 -p build/${NAME}_${VERSION}/lib/systemd/system
 cp ../${NAME}.service build/${NAME}_${VERSION}/lib/systemd/system/

-mkdir -p build/${NAME}_${VERSION}/usr/bin
+mkdir -m 0755 -p build/${NAME}_${VERSION}/usr/bin
 cp ../${NAME} build/${NAME}_${VERSION}/usr/bin/

-mkdir -p build/${NAME}_${VERSION}/usr/share/doc/${NAME}
+mkdir -m 0755 -p build/${NAME}_${VERSION}/usr/share/doc/${NAME}
 cp ../README.md build/${NAME}_${VERSION}/usr/share/doc/${NAME}/
+mv build/copyright build/${NAME}_${VERSION}/usr/share/doc/${NAME}
+chmod 0644 build/${NAME}_${VERSION}/usr/share/doc/${NAME}/copyright
+mv build/changelog.Debian build/${NAME}_${VERSION}/usr/share/doc/${NAME}
+gzip -9 -n build/${NAME}_${VERSION}/usr/share/doc/${NAME}/changelog.Debian
+chmod 0644 build/${NAME}_${VERSION}/usr/share/doc/${NAME}/changelog.Debian.gz

-mkdir -p build/${NAME}_${VERSION}/usr/share/man/man1
+mkdir -m 0755 -p build/${NAME}_${VERSION}/usr/share/man/man1
 cp ../${NAME}.1 build/${NAME}_${VERSION}/usr/share/man/man1/
-bzip2 build/${NAME}_${VERSION}/usr/share/man/man1/${NAME}.1
+gzip -9 -n build/${NAME}_${VERSION}/usr/share/man/man1/${NAME}.1

 cd build
 dpkg-deb --root-owner-group --build ${NAME}_${VERSION}
--- a/redhat/package-rpm
+++ b/redhat/package-rpm
@ -28,6 +28,9 @@ cat > build/${NAME}.spec <<EOL
 Name:		${NAME}
 Version:	${VERSION}
 Release:	${RELEASE}%{?dist}
+URL:		https://github.com/dmatetelki/battery-status-led
+Packager:	Denes Matetelki <denes.matetelki@gmail.com>
+
 Summary:	Battery status indication on an LED

 Group:          Utilities
@ -40,7 +43,7 @@ Source2:	README.md
 Source3:	${NAME}.1

 %description
-Battery (low/critical) status indication by making a (the capslock) LED blink
+Battery (low/critical) status indication by making a (the caps-lock) LED blink

 # %prep

@ -54,25 +57,30 @@ install -p -m 0644 %{SOURCE2} %{buildroot}%{_docdir}/${NAME}/
 mkdir -p %{buildroot}/%{_mandir}/man1
 install -p -m 0644 %{SOURCE3} %{buildroot}%{_mandir}/man1/

-# %clean
+%clean
+rm -rf %{buildroot}

 %files
 %defattr(-,root,root,-)
 %{_unitdir}/${NAME}.service
 %{_bindir}/${NAME}
 %{_docdir}/${NAME}/README.md
-%{_mandir}/man1/${NAME}.1.gz
+%{_mandir}/man1/${NAME}.1.*
+
+%changelog
+* Fri Aug 31 2018 Denes Matetelki <denes.matetelki@gmail.com> - 0.1-1
+- Initial release

-# %changelog
 EOL

 cp ../${NAME}.service build/
 cp ../${NAME} build/
 cp ../README.md build/
 cp ../${NAME}.1 build/
+# bzip2 -z -9 build/${NAME}.1

 cd build
 rpmbuild --define "_sourcedir $PWD" --define "_rpmdir $PWD" --define "_unitdir /lib/systemd/system"  -bb ${NAME}.spec
 cd ..
 mv build/noarch/${NAME}-${VERSION}-${RELEASE}.noarch.rpm .
-rm -rf build
+#rm -rf build